Report a score for disabled queries #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
added a commit
to mondoohq/cnquery
that referenced
this pull request
Dec 2, 2024
imilchev
pushed a commit
to mondoohq/cnquery
that referenced
this pull request
Dec 3, 2024
This reports them as skipped. It does this by injecting a query which always reports a skipped score. Doing so allows us to know if an asset didn't run a query that would have because it is skipped
jaym
force-pushed
the
jdm/report-disabled
branch
from
7f5dc55 to
9b1a0a1
Compare
imilchev
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reports them as skipped for old clients, disabled for new clients. It does this by injecting a query which always reports a skipped score. Doing so allows us to know if an asset didn't run a query that would have because it is disabled